Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow Hosting Provider dialog #7594

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Jan 26, 2025

Refactors the hosting provider dialog - it fell into the trap of the cross-portal state changes being really slow. Most state is moved down into the dialog

Test plan

Confirm no functionality changes

Copy link

github-actions bot commented Jan 26, 2025

Old size New size Diff
7 MB 7 MB 505 B (0.01%)

Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just one nit

src/view/com/auth/server-input/index.tsx Outdated Show resolved Hide resolved
@arcalinea arcalinea temporarily deployed to samuel/fix-slow-hostingprovider - social-app PR #7594 February 3, 2025 22:41 — with Render Destroyed
@mozzius mozzius merged commit 083a5c9 into main Feb 3, 2025
7 checks passed
@mozzius mozzius deleted the samuel/fix-slow-hostingprovider branch February 3, 2025 22:50
estrattonbailey added a commit that referenced this pull request Feb 5, 2025
* origin/main: (100 commits)
  Adding webp to regex list. Added function return type for consistency with the rest of the functions (#7649)
  bump version (#7650)
  use did for userID (#7647)
  Upgrade RN to 0.76.6 (#7557)
  Update expo-blur (#7596)
  Fix slow Hosting Provider dialog (#7594)
  make convo menu lazy (#7604)
  Fix convo header loading state (#7603)
  Spring cleaning (#7640)
  Date input improvements (#7639)
  Add example account store (#7641)
  rm refs in render (#7589)
  change search cancel behaviour (#7624)
  reduce padding on video overlay (#7617)
  Typo fix (#7637)
  no follow self (#7606)
  env var tweaks (#7457)
  Test fix
  Add Danish localization (#7220)
  Add Swedish localization (#7232)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants